fix: subtitle syncing issues #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to avoid inconsistencies
forgotvas
approved these changes
Jan 20, 2025
shafqat-muneer
requested changes
Jan 21, 2025
| if viewModel.isPlaying { | ||
| isAnimating = true | ||
|
|
||
| withAnimation(.linear(duration: 0.3)) { |
There was a problem hiding this comment.
Suggestion: I think we should move it to a private property so that if we need to change the auto-scroll time later, anyone can simply update this value without digging deep into the code. WDYT?
There was a problem hiding this comment.
I have put the constants in a private enum.
shafqat-muneer
pushed a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LEARNER-10314: iOS - Transcript gets out of sync when user seeks the video
Following scenarios have been implemented.
Here's a quick demo of the implementation.
Subtitle.Sync.Demo.mov