Merge pull request #7 from edx/mfrank/fix-product-types-hook

fix: product types hook
edx · Jul 6, 2023 · 5ad3ea2 · 5ad3ea2
2 parents cd51ae5 + b8e340d
commit 5ad3ea2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/skills-builder/skills-builder-modal/view-results/data/hooks.js b/src/skills-builder/skills-builder-modal/view-results/data/hooks.js
@@ -16,7 +16,7 @@ export const useProductTypes = () => {
 
   if (search) {
     // remove the "?" and split the query string at "="
-    const splitString = search.slice(1).split('=');
+    const splitString = search.slice(1).split('&')[0].split('=');
 
     // if the key is not "product_types", use a default setting
     if (splitString[0] !== 'product_types') {

diff --git a/src/skills-builder/skills-builder-modal/view-results/data/test/hooks.test.jsx b/src/skills-builder/skills-builder-modal/view-results/data/test/hooks.test.jsx
@@ -43,4 +43,14 @@ describe('useProductTypes', () => {
 
     expect(productTypes).toEqual(['boot_camp', 'course']);
   });
+
+  test('returns a filtered list if additional key-value pairs are provided in the query string', () => {
+    global.query_string = '?product_types=boot_camp,course&external_link=true';
+
+    const { result } = renderHook(() => useProductTypes());
+
+    const productTypes = result.current;
+
+    expect(productTypes).toEqual(['boot_camp', 'course']);
+  });
 });