Skip to content

Commit

Permalink
Merge pull request #4 from edx/mfrank/remove-header
Browse files Browse the repository at this point in the history
chore: remove header dependency
  • Loading branch information
MaxFrank13 committed Jun 8, 2023
2 parents 9b1d19e + 95410a8 commit 69fdc9a
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 180 deletions.
186 changes: 13 additions & 173 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@
"url": "https://github.com/openedx/frontend-app-skills/issues"
},
"dependencies": {
"@edx/brand": "npm:@edx/brand-openedx@1.2.0",
"@edx/brand": "npm:@edx/brand-edx.org@^2.1.2",
"@edx/frontend-component-footer": "12.0.0",
"@edx/frontend-component-header": "4.0.0",
"@edx/frontend-platform": "4.2.0",
"@edx/paragon": "^20.20.0",
"@fortawesome/fontawesome-svg-core": "1.2.36",
Expand Down
2 changes: 0 additions & 2 deletions src/i18n/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { messages as headerMessages } from '@edx/frontend-component-header';
import { messages as footerMessages } from '@edx/frontend-component-footer';

import arMessages from './messages/ar.json';
Expand Down Expand Up @@ -33,7 +32,6 @@ const appMessages = {
};

export default [
headerMessages,
footerMessages,
appMessages,
];
2 changes: 0 additions & 2 deletions src/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import {
import { AppProvider, ErrorPage, PageRoute } from '@edx/frontend-platform/react';
import ReactDOM from 'react-dom';

import Header from '@edx/frontend-component-header';
import Footer from '@edx/frontend-component-footer';
import { SkillsBuilder } from './skills-builder';
import messages from './i18n';
Expand All @@ -17,7 +16,6 @@ import './index.scss';
subscribe(APP_READY, () => {
ReactDOM.render(
<AppProvider>
<Header />
<PageRoute path="/" component={SkillsBuilder} />
<Footer />
</AppProvider>,
Expand Down
1 change: 0 additions & 1 deletion src/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
@import "@edx/paragon/scss/core/core.scss";
@import "@edx/brand/paragon/overrides.scss";

@import "~@edx/frontend-component-header/dist/index";
@import "~@edx/frontend-component-footer/dist/footer";

@import './skills-builder/skills-builder-modal/skillsBuilderModal.scss';
Expand Down

0 comments on commit 69fdc9a

Please sign in to comment.