fix: copy changes and job list edits (#64)

* fix: copy changes and job list edits * fix: changed to camelcase * fix: fixed tests * fix: remove Digital Marketing Consultant and use messages in test files --------- Co-authored-by: Maxwell Frank <[email protected]>
edx · Sep 21, 2023 · becb5f5 · becb5f5
1 parent c71933b
commit becb5f5
Show file tree

Hide file tree

Showing 14 changed files with 367 additions and 447 deletions.
diff --git a/src/skills-builder/skills-builder-steps/SkillsBuilderDefault.jsx b/src/skills-builder/skills-builder-steps/SkillsBuilderDefault.jsx
@@ -51,7 +51,7 @@ const SkillsBuilderDefault = () => {
       <Stepper activeKey={currentStep}>
 
         <Stepper.Header compactWidth="md" className="bg-white mb-4.5" />
-        <Container size="md">
+        <Container size="md" className="mb-4.5">
           <Form>
             <Stepper.Step eventKey={STEP1} title={formatMessage(messages.selectPreferences)}>
               <SelectPreferences />
@@ -66,7 +66,7 @@ const SkillsBuilderDefault = () => {
                 onClick={nextStepHandle}
                 disabled={careerInterests.length === 0}
               >
-                {formatMessage(messages.nextStepButton)}
+                {formatMessage(messages.showRecommendationsButton)}
               </Button>
             </Stepper.ActionRow>
 

diff --git a/src/skills-builder/skills-builder-steps/data/jobsByCategory.json b/src/skills-builder/skills-builder-steps/data/jobsByCategory.json
@@ -0,0 +1,302 @@
+{
+   "coding": [
+      {
+         "jobTitle": "Android Developer"
+      },
+      {
+         "jobTitle": "Application Developer"
+      },
+      {
+         "jobTitle": "Back End Developer"
+      },
+      {
+         "jobTitle": "Business Systems Analyst"
+      },
+      {
+         "jobTitle": "Coding Instructor"
+      },
+      {
+         "jobTitle": "Cybersecurity Analyst"
+      },
+      {
+         "jobTitle": "DevOps Engineer"
+      },
+      {
+         "jobTitle": "Front End Developer"
+      },
+      {
+         "jobTitle": "Front End Software Engineer"
+      },
+      {
+         "jobTitle": "Full Stack Developer"
+      },
+      {
+         "jobTitle": "Full Stack Software Engineer"
+      },
+      {
+         "jobTitle": "IT Support Specialist"
+      },
+      {
+         "jobTitle": "Java Developer"
+      },
+      {
+         "jobTitle": "Lead Software Engineer"
+      },
+      {
+         "jobTitle": "Mobile Developer"
+      },
+      {
+         "jobTitle": "Principal Software Engineer"
+      },
+      {
+         "jobTitle": "Quality Assurance Analyst"
+      },
+      {
+         "jobTitle": "Software Developer"
+      },
+      {
+         "jobTitle": "Software Development Engineer"
+      },
+      {
+         "jobTitle": "Software Engineer"
+      },
+      {
+         "jobTitle": "Software Engineering Intern"
+      },
+      {
+         "jobTitle": "Technical Program Manager"
+      },
+      {
+         "jobTitle": "UI Designer"
+      },
+      {
+         "jobTitle": "UX Designer"
+      },
+      {
+         "jobTitle": "Web Developer"
+      },
+      {
+         "jobTitle": "iOS Developer"
+      }
+   ],
+   "business": [
+      {
+         "jobTitle": "Account Executive"
+      },
+      {
+         "jobTitle": "Account Manager"
+      },
+      {
+         "jobTitle": "Accountant"
+      },
+      {
+         "jobTitle": "Administrative Assistant"
+      },
+      {
+         "jobTitle": "Agile Coach"
+      },
+      {
+         "jobTitle": "Agile Project Manager"
+      },
+      {
+         "jobTitle": "Appraiser"
+      },
+      {
+         "jobTitle": "Bookkeeper"
+      },
+      {
+         "jobTitle": "Budget Analyst"
+      },
+      {
+         "jobTitle": "Business Analyst"
+      },
+      {
+         "jobTitle": "Business Development Manager"
+      },
+      {
+         "jobTitle": "Business Risk Manager"
+      },
+      {
+         "jobTitle": "Business Support Analyst"
+      },
+      {
+         "jobTitle": "Business Systems Administrator"
+      },
+      {
+         "jobTitle": "Buyer"
+      },
+      {
+         "jobTitle": "Chief Executive Officer"
+      },
+      {
+         "jobTitle": "Chief Financial Officer"
+      },
+      {
+         "jobTitle": "Chief Operations Officer/General Manager"
+      },
+      {
+         "jobTitle": "Commercial Insurance Broker"
+      },
+      {
+         "jobTitle": "Compensation Analyst"
+      },
+      {
+         "jobTitle": "Finance Manager"
+      },
+      {
+         "jobTitle": "Financial Analyst"
+      },
+      {
+         "jobTitle": "Fundraiser"
+      },
+      {
+         "jobTitle": "Growth Marketing Manager"
+      },
+      {
+         "jobTitle": "Human Resources Consultant"
+      },
+      {
+         "jobTitle": "Human Resources Project Manager"
+      },
+      {
+         "jobTitle": "IT Project Manager"
+      },
+      {
+         "jobTitle": "Investment Banking Analyst"
+      },
+      {
+         "jobTitle": "Loan Officer"
+      },
+      {
+         "jobTitle": "Procurement Specialist"
+      },
+      {
+         "jobTitle": "Program Manager"
+      },
+      {
+         "jobTitle": "Project Manager"
+      },
+      {
+         "jobTitle": "Senior Business Analyst"
+      },
+      {
+         "jobTitle": "Senior Project Manager"
+      },
+      {
+         "jobTitle": "Student Success Coach"
+      },
+      {
+         "jobTitle": "Technical Project Manager"
+      },
+      {
+         "jobTitle": "Technology Consultant"
+      }
+   ],
+   "productManagement": [
+      {
+         "jobTitle": "Associate Product Manager"
+      },
+      {
+         "jobTitle": "Digital Product Manager"
+      },
+      {
+         "jobTitle": "Director of Product Management"
+      },
+      {
+         "jobTitle": "Lead Product Manager"
+      },
+      {
+         "jobTitle": "Marketing Product Manager"
+      },
+      {
+         "jobTitle": "Product Analyst"
+      },
+      {
+         "jobTitle": "Product Owner"
+      }
+   ],
+   "data": [
+      {
+         "jobTitle": "Analytics Manager"
+      },
+      {
+         "jobTitle": "Business Intelligence Analyst"
+      },
+      {
+         "jobTitle": "Data Analyst"
+      },
+      {
+         "jobTitle": "Data Analytics Scientist"
+      },
+      {
+         "jobTitle": "Data Architect"
+      },
+      {
+         "jobTitle": "Data Engineer"
+      },
+      {
+         "jobTitle": "Data Entry Clerk"
+      },
+      {
+         "jobTitle": "Data Science Manager"
+      },
+      {
+         "jobTitle": "Data Scientist"
+      },
+      {
+         "jobTitle": "Database Developer"
+      },
+      {
+         "jobTitle": "Director of Data Science"
+      },
+      {
+         "jobTitle": "Machine Learning Engineer"
+      },
+      {
+         "jobTitle": "Manager/Data Scientist"
+      },
+      {
+         "jobTitle": "Research Scientist"
+      }
+   ],
+   "artificialIntelligence": [
+      {
+         "jobTitle": "Artificial Intelligence Engineer"
+      }
+   ],
+   "communications": [
+      {
+         "jobTitle": "Communications Coordinator"
+      },
+      {
+         "jobTitle": "Director of Communications"
+      },
+      {
+         "jobTitle": "Marketing Analyst"
+      },
+      {
+         "jobTitle": "Marketing Manager"
+      },
+      {
+         "jobTitle": "Media Planner"
+      },
+      {
+         "jobTitle": "Public Relations Specialist"
+      },
+      {
+         "jobTitle": "Sales Development Representative"
+      },
+      {
+         "jobTitle": "Sales Operations Specialist"
+      },
+      {
+         "jobTitle": "Sales Representative"
+      },
+      {
+         "jobTitle": "Social Media Manager"
+      },
+      {
+         "jobTitle": "Technical Writer"
+      }
+   ]
+}
diff --git a/src/skills-builder/skills-builder-steps/messages.js b/src/skills-builder/skills-builder-steps/messages.js
@@ -12,6 +12,11 @@ const messages = defineMessages({
     defaultMessage: 'Next Step',
     description: 'Button that sends the user to the next step in the skills builder.',
   },
+  showRecommendationsButton: {
+    id: 'show.recommmendations.button',
+    defaultMessage: 'Show Recommendations',
+    description: 'Button that sends the user to the next step in the skills builder.',
+  },
   exitButton: {
     id: 'exit.button',
     defaultMessage: 'Exit',

diff --git a/src/skills-builder/skills-builder-steps/select-preferences/CareerInterestCategorizinator.jsx b/src/skills-builder/skills-builder-steps/select-preferences/CareerInterestCategorizinator.jsx
@@ -9,7 +9,7 @@ import CareerInterestCard from './CareerInterestCard';
 import { addCareerInterest, clearAllCareerInterests, setExpandedList } from '../../skills-builder-context/data/actions';
 import { SkillsBuilderContext } from '../../skills-builder-context';
 import messages from './messages';
-import { careerList } from '../../utils/jobsByCategory';
+import careerList from '../data/jobsByCategory.json';
 import { VisibilityFlagsContext } from '../../visibility-flags-context';
 import { FORM_VALUES } from './data/constants';
 
@@ -21,7 +21,6 @@ const CareerInterestCategorizinator = () => {
   const { showCareerInterestCards, allowMultipleCareerInterests, isProgressive } = visibilityFlagsState;
 
   const handleCareerInterestSelect = (value) => {
-    // TODO: test event payload
     dispatch(setExpandedList([]));
     if (!allowMultipleCareerInterests && careerInterests.length > 0) {
       dispatch(clearAllCareerInterests(value));
@@ -71,7 +70,7 @@ const CareerInterestCategorizinator = () => {
         <option disabled={controlState}>{title}</option>
         {currentCategory.map((job, idx) => (
           // eslint-disable-next-line react/no-array-index-key
-          <option key={idx}>{job.JobTitle}</option>
+          <option key={idx}>{job.jobTitle}</option>
         ))}
       </Form.Control>
     );
@@ -93,14 +92,14 @@ const CareerInterestCategorizinator = () => {
       <Stack
         direction="horizontal"
         gap={3}
-        className="flex-wrap"
+        className="flex-wrap mb-4.5"
       >
-        {populateDropdown('ArtificialIntelligence', 'Artificial Intelligence')}
-        {populateDropdown('Business')}
-        {populateDropdown('Coding')}
-        {populateDropdown('Communications')}
-        {populateDropdown('Data')}
-        {populateDropdown('ProductManagement', 'Product Management')}
+        {populateDropdown('artificialIntelligence', 'Artificial Intelligence')}
+        {populateDropdown('business', 'Business')}
+        {populateDropdown('coding', 'Coding')}
+        {populateDropdown('communications', 'Communications')}
+        {populateDropdown('data', 'Data')}
+        {populateDropdown('productManagement', 'Product Management')}
       </Stack>
       { showCareerInterestCards && (
         <Row>
@@ -112,7 +111,6 @@ const CareerInterestCategorizinator = () => {
           ))}
         </Row>
       )}
-
     </Stack>
   );
 };