Skip to content

Make tuttle work with very active repos that are deployed into a subcollection #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DrRataplan
Copy link
Collaborator

@DrRataplan DrRataplan commented May 27, 2025

  • Change front-end to send the collection uri-encoded. Roaster will decode that before calling the handler. Makes working with subcollections possible
  • Search for a commit over multiple pages, up to 500 total commits. This makes upgrades over multiple pages work.

This allows subcollections to be under tuttle command, like `/db/apps/main-data/sub-data`
@DrRataplan DrRataplan requested a review from line-o May 27, 2025 13:45
@DrRataplan DrRataplan force-pushed the fix/betmas-collections branch from ec3d411 to 3b07bf0 Compare May 27, 2025 13:46
@DrRataplan DrRataplan force-pushed the fix/betmas-collections branch 3 times, most recently from 48e02a3 to 233750a Compare May 27, 2025 13:49
@DrRataplan DrRataplan force-pushed the fix/betmas-collections branch 11 times, most recently from a6fd312 to 5294e6b Compare June 20, 2025 13:51
@DrRataplan DrRataplan requested a review from line-o June 24, 2025 09:02
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to add a test for this important feature.
I think it is worth to give the stop-condition parameter another thought.

Is it necessary to recheck all previous results? There might be legit reasons like number of all commits read, but this hard-limit is handled elsewhere as I understand the code.

I think I would prefer github:get-raw-commits to accept the stop-condition as a function. That has more re-use potential than to limit it to just until-sha.
What do you think?

@DrRataplan DrRataplan force-pushed the fix/betmas-collections branch from 5294e6b to 12f26a3 Compare June 24, 2025 11:03
This makes tuttle viable for very active repos where there may be 100 commits in no time!
@DrRataplan DrRataplan force-pushed the fix/betmas-collections branch from 12f26a3 to f643e25 Compare June 24, 2025 11:05
@DrRataplan
Copy link
Collaborator Author

Thanks for taking the time to add a test for this important feature. I think it is worth to give the stop-condition parameter another thought.

Is it necessary to recheck all previous results? There might be legit reasons like number of all commits read, but this hard-limit is handled elsewhere as I understand the code.

I think I would prefer github:get-raw-commits to accept the stop-condition as a function. That has more re-use potential than to limit it to just until-sha. What do you think?

Not sure whether I agree. it's a simple refactoring if we do need it. I'd rather do it when we need it instead of making this code more complex to be honest.

@line-o line-o self-requested a review June 25, 2025 16:31
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants