-
-
Notifications
You must be signed in to change notification settings - Fork 3
Make tuttle work with very active repos that are deployed into a subcollection #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This allows subcollections to be under tuttle command, like `/db/apps/main-data/sub-data`
Makes debugging easier
ec3d411
to
3b07bf0
Compare
48e02a3
to
233750a
Compare
a6fd312
to
5294e6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to add a test for this important feature.
I think it is worth to give the stop-condition parameter another thought.
Is it necessary to recheck all previous results? There might be legit reasons like number of all commits read, but this hard-limit is handled elsewhere as I understand the code.
I think I would prefer github:get-raw-commits
to accept the stop-condition as a function. That has more re-use potential than to limit it to just until-sha.
What do you think?
5294e6b
to
12f26a3
Compare
This makes tuttle viable for very active repos where there may be 100 commits in no time!
12f26a3
to
f643e25
Compare
Not sure whether I agree. it's a simple refactoring if we do need it. I'd rather do it when we need it instead of making this code more complex to be honest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Uh oh!
There was an error while loading. Please reload this page.