Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4 stable working #1

Open
wants to merge 2 commits into
base: 3-0-stable
Choose a base branch
from
Open

Conversation

rdaniels
Copy link

Thanks for writing this, the Spree Reports out of the box are really lacking substance, and I don't really like the Vinsol reports, so this was a good find.

I've updated this to work with 3.4, starting with your code saved me a ton of time so thank you.
I also removed

where(spree_payments: { state: :completed })

from all queries. This was preventing output for me. Also had to do a few other tweaks to get it to work with 3.4, I kept as much of the original reports and intent as I could.

No tests setup, so all passed :)

Finished in 0.00044 seconds (files took 0.24835 seconds to load)
0 examples, 0 failures

thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant