Fix invisble wall encoding in CCL/DAT files #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The real invisible wall tile 0x05 was getting overwritten by 0x20 in CCL (aka DAT) exports. I also took the liberty of changing the byte-range check to simple equality tests since I think that's clearer in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real invisible wall tile 0x05 was getting overwritten by 0x20 in CCL (aka DAT) exports. (is it worth adding some sort overwrite check in the reverse index lookup? probably not but it's what popped in my head)
I also took the liberty of changing the byte-range check to simple equality tests since I think that's clearer in this case — I hope that's okay!
I noticed this when trying to convert my exported CCL levels to PAK format with c4 and it kept complaining about "non-lynx objects". I dug into it & presto bug found bug (hopefully) fixed!