Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue739 junit5 ext dependency inversion #740

Merged
merged 5 commits into from
Oct 16, 2022

Conversation

eeverman
Copy link
Owner

@eeverman eeverman commented Oct 16, 2022

All Submissions:

Thank you! Please check that...

  • You branched from the main branch and the pull request is to the main branch
  • Your code is up to date with the latest code from main
  • You followed the guidelines in the Contributing Guide?
  • Your code does not decrease test coverage of existing code, and is near 100% for new code
  • If this is related to an issue, please include a link to the issue with the 'Fixes #XXX' syntax.

Fixes #739

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 89.53% // Head: 89.53% // No change to project coverage 👍

Coverage data is based on head (15ad4c3) compared to base (0effe4d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #740   +/-   ##
=========================================
  Coverage     89.53%   89.53%           
  Complexity     1230     1230           
=========================================
  Files           136      136           
  Lines          3661     3661           
  Branches        434      434           
=========================================
  Hits           3278     3278           
  Misses          273      273           
  Partials        110      110           
Impacted Files Coverage Δ
.../org/yarnandtail/andhow/junit5/EnableJndiUtil.java 87.50% <ø> (ø)
...dhow/junit5/ext/EnableJndiForThisTestClassExt.java 100.00% <ø> (ø)
...how/junit5/ext/EnableJndiForThisTestMethodExt.java 100.00% <ø> (ø)
...g/yarnandtail/andhow/junit5/ext/ExtensionBase.java 100.00% <ø> (ø)
...ow/junit5/ext/RestoreSysPropsAfterEachTestExt.java 100.00% <ø> (ø)
...ow/junit5/ext/RestoreSysPropsAfterThisTestExt.java 100.00% <ø> (ø)
...andhow/junit5/ext/KillAndHowBeforeAllTestsExt.java 100.00% <ø> (ø)
...andhow/junit5/ext/KillAndHowBeforeEachTestExt.java 100.00% <ø> (ø)
...andhow/junit5/ext/KillAndHowBeforeThisTestExt.java 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eeverman eeverman merged commit 9b8879a into main Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants