Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Python 3.13 in GitHub Actions and add its trove classification to pyproject.toml #15

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Jun 6, 2024

Summary by Sourcery

This pull request updates the GitHub Actions workflows to support Python 3.13 by adding it to the test matrix and upgrading the 'actions/setup-python' action to version 5. Additionally, it allows pre-release versions of Python in the setup.

  • CI:
    • Updated GitHub Actions workflows to include Python 3.13 in the test matrix.
    • Upgraded 'actions/setup-python' to version 5 in the GitHub Actions workflows.

sourcery-ai[bot]

This comment was marked as off-topic.

@rffontenelle
Copy link
Contributor Author

It looks like pre-commit didn't like me adding "Programming Language :: Python :: 3.13" although it is valid as per https://pypi.org/classifiers/

@egeakman
Copy link
Owner

egeakman commented Jun 6, 2024

Hey @rffontenelle thanks for the PR! The issue comes from pyproject-fmt. This report from Hugo seems relevant: tox-dev/pyproject-fmt#198

This addition to the pyproject.toml might fix it:

[tool.pyproject-fmt]
max_supported_python = "3.13"

Repository owner deleted a comment from sourcery-ai bot Jun 6, 2024
@rffontenelle
Copy link
Contributor Author

Nice. Setting the upper bound made pre-commit add 3.13 trove classification.

@egeakman
Copy link
Owner

egeakman commented Jun 7, 2024

Thanks @rffontenelle ❤️

@egeakman egeakman merged commit 2cccb20 into egeakman:main Jun 7, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants