Add bulk version of fast-api airflow example #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "common_5_key": self.onboard_item.common5, | ||
|
|
||
| # AWS related configs | ||
| "aws_common_value_example_1": os.environ["example1"], |
There was a problem hiding this comment.
I think it is sufficient to define 2-3 example here.
| tpa_payload = { | ||
| "specific_key_1": "specific_value_1", | ||
| "specific_key_2": "specific_value_2", | ||
| "specific_key_3": "specific_value_3", |
| "specific_key_1": "specific_value_1", | ||
| "specific_key_2": "specific_value_2", | ||
| "specific_key_3": "specific_value_3", | ||
| "specific_key_4": "specific_value_4", |
There was a problem hiding this comment.
Same applies here, we can keep the number of parameters consistent
| EXAMPLE_2 = ("Example2", Example_2_OnboardItem) | ||
| EXAMPLE_3 = ("Example3", Example_3_OnboardItem) | ||
| # EXAMPLE_4 = ("Example4", Example_4_OnboardItem) | ||
| # EXAMPLE_5 = ("Example5", Example_5_OnboardItem) |
There was a problem hiding this comment.
We can remove extra examples here, and keep it consistent with other files
|
|
||
| ### Insight | ||
|
|
||
| Using the factory pattern enhances the readability and maintainability of the code. Additionally, there is neat code present before anything else. CAUTION: While it could be implemented more effectively using a different pattern, it is being used for educational purposes. Also code will not work if you try to run it. No newline at end of file |
There was a problem hiding this comment.
do we have any reference to any other source? if we have, we should also mention them in a credits topic. You can refer to other README.md files
| @@ -0,0 +1,30 @@ | |||
| # Real world example: | |||
|
|
|||
| Here is the realworld example that I have used for one of my project with factory_pattern. | |||
|
|
||
| from data_models import ExampleTPA | ||
|
|
||
| class OnboardItemValidator: |
| Files | ||
| ``` | ||
| ... | ||
| - main.py --> Fast-API app |
There was a problem hiding this comment.
we should add a direct link to these files.
Example:(https://stackoverflow.com/questions/32563078/how-link-to-any-local-file-with-markdown-syntax)
egehanyorulmaz
requested changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.