remove quick-logs, line buffer instead #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelortmann
changed the title
thommey
requested changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes: #1449
One-line summary:
remove quick-logs, line buffer instead
Additional description (if needed):
remove quick-logs
quick logs disabled meant file logfile was buffered with
flush()every 5 minuesquick logs enabled meant logfile was buffered
flush()every minutenow, instead, we dont explicitely flush, but set logfile to line buffered
setvbuf(_IOLBF)is posix 2001Please regenerate docs via sphinx after merge
Test cases demonstrating functionality (if applicable):