Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging of QUIT msg #1488

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Fix logging of QUIT msg #1488

merged 3 commits into from
Jan 3, 2024

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Oct 14, 2023

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Log QUIT msg like we already do for any other msg sent to the server.

Additional description (if needed):
Messages from eggdrop to irc server are logged when raw-log is set. depending on the queue the message was put in, it gets logged like for example [m->] or [s->] The Quit message was sent to server directly without using those queues and thus was not logged.

Test cases demonstrating functionality (if applicable):
in eggdrop.conf set raw-log 1

.die
[23:29:24] tcl: builtin dcc call: *dcc:die -HQ 1 
[23:29:24] #-HQ# die 
[23:29:24] [->] QUIT :-HQ

Copy link
Member

@thommey thommey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it was there before but quit_msg[0] ? quit_msg : "" seems pointless, quit_msg is the same.
Otherwise LGTM

@thommey thommey added this to the v1.10.0 milestone Dec 30, 2023
@michaelortmann
Copy link
Member Author

I know it was there before but quit_msg[0] ? quit_msg : "" seems pointless, quit_msg is the same. Otherwise LGTM

good find, cleanup done.

@michaelortmann michaelortmann requested a review from thommey January 3, 2024 22:42
@vanosg vanosg removed the request for review from thommey January 3, 2024 23:23
@vanosg vanosg merged commit a41e1ba into eggheads:develop Jan 3, 2024
2 checks passed
@michaelortmann michaelortmann deleted the log.quit branch January 3, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants