Crashfix: CFLAGS -fsanitize=address could lead to crash if pbkdf2 mod loaded #1505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Compiling eggdrop with
CFLAGS
-fsanitize=address
on systems that require linker flag-lresolv
forb64_ntop()
orb64_pton()
could lead to crash if pbkdf2 mod loadedAdditional description (if needed):
gccs sanitizer will intercept calls to
b64_ntop
orb64_pton()
https://github.com/gcc-mirror/gcc/blob/releases/gcc-13/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc#L2512
which leads to eggdrops configure script misdetecting that eggdrop can be linked without
-lresolv
to call those functions.Please run
misc/runautotools
after merging or for testing this PRTest cases demonstrating functionality (if applicable):
Before:
After: