-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runtime python version check #1625
Conversation
The version check is pointless because it's not runtime. Runtime version check seems to be unsupported until much later Python versions unless you can find a workaround? |
We would also have to fix: 093cc36#diff-43cfee5e2cf04e6a2a99e0e92600b37c9701db5d94adf8d515785f97c1ebe626 ? What does "much later" mean? https://docs.python.org/2.6/c-api/init.html#Py_GetVersion Digging deeper, since at least python 2.2: https://docs.python.org/release/2.2/api/initialization.html Not enough? |
Because the version is checked at compile, please remove the check here. This is an artifact from before the check was added to compile. Thanks! |
Done. I left the change to |
I confused Py_GetVersion with Py_Version (constant) which has only been added to 3.11, looks good to me |
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Fix runtime python version check
Additional description (if needed):
Test cases demonstrating functionality (if applicable):