Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise CHANNELLEN to the maximum of 200 chars defined by rfc1459 #1651

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

michaelortmann
Copy link
Member

Found by: pseudo (see #38)
Patch by: michaelortmann
Fixes: #38

One-line summary:
Raise CHANNELLEN to the maximum of 200 chars defined by rfc1459 and used by networks like undernet

Additional description (if needed):
Its a big bad bug to if eggdrop cant deal with channels with channelnames longer than 80 chars.

Test cases demonstrating functionality (if applicable):
At least themajor network undernet supports the max channel name len of 200.

Copy link
Member

@vanosg vanosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not specifically addressed in this PR but maybe missed when this was implemented- based on the use of last_invchan in chan.c:1779, I think the definition of last_invchan needs to be NICKLEN+CHANNELLEN+1, can you confirm/change?

@michaelortmann
Copy link
Member Author

Not specifically addressed in this PR but maybe missed when this was implemented- based on the use of last_invchan in chan.c:1779, I think the definition of last_invchan needs to be NICKLEN+CHANNELLEN+1, can you confirm/change?

CHANNELLEN+1 as it is, is correct. parameter msg in this function is really only <#channelname>

[23:55:37] [@] :michael!michael@Clk-8553FB0D INVITE BotA :#test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for channels with arbitrary length (and get rid of dname/name duplicate)
3 participants