Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yet another tcl search path for macOS #1675

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Aug 17, 2024

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Add yet another tcl search path for macOS

Additional description (if needed):
On my newly installed macOS, eggdrop still doesnt find tclConfig.sh
Even after #1649
When i looked for it, i found Tcl is installed but Xcode (where eggdrop searches) is not:

$ ls -la /Applications
total 0
drwxrwxr-x   5 root  admin  160 Jul 19 04:41 .
drwxr-xr-x  20 root  wheel  640 Jul 19 04:41 ..
-rw-r--r--   1 root  wheel    0 Jul 19 04:41 .localized
lrwxr-xr-x@  1 root  wheel   54 Jul 19 04:41 Safari.app -> ../System/Cryptexes/App/System/Applications/Safari.app
drwxr-xr-x   3 root  wheel   96 Jul 19 04:41 Utilities

So this PR adds yet another search path, and voila, looks like eggdrop is not dependent on Xcode anymore :)

Test cases demonstrating functionality (if applicable):

$ uname -a
Darwin michaels-iMac-Pro.local 22.6.0 Darwin Kernel Version 22.6.0: Mon Jun 24 01:25:37 PDT 2024; root:xnu-8796.141.3.706.2~1/RELEASE_X86_64 x86_64

This is macOS 13.6.8

configure: Autoconfiguring Tcl with tclConfig.sh
checking for correct TEA configuration... ok (TEA 3.10)
configure: configuring Eggdrop 1.10.0
checking for Tcl configuration... found /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Tcl.framework/tclConfig.sh
checking for existence of /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Tcl.framework/tclConfig.sh... loading
checking platform... unix
checking for sin... yes
checking for main in -lieee... no
checking for main in -linet... no
checking for net/errno.h... no
checking for connect... yes
checking for gethostbyname... yes
checking for Tcl linker... ${CC} -dynamiclib ${CFLAGS} ${LDFLAGS} -Wl,-single_module
checking for Tcl version... 8.5.9
checking for Tcl library flags... -F/System/Library/Frameworks -framework Tcl -lpthread -framework CoreFoundation
checking for Tcl header flags... -iwithsysroot /System/Library/Frameworks/Tcl.framework/Versions/8.5/Headers
checking whether C compiler accepts -Og... yes
checking for system IPv6 support... yes
checking for struct in6_addr... yes
checking for the in6addr_any constant... yes
checking for the in6addr_loopback constant... yes
checking for struct sockaddr_in6... yes
checking whether to enable TLS support... no
configure: creating ./config.status
config.status: creating Makefile
config.status: creating doc/Makefile
config.status: creating scripts/Makefile
config.status: creating src/Makefile
config.status: creating src/compat/Makefile
config.status: creating src/md5/Makefile
config.status: creating src/mod/Makefile
config.status: creating config.h
config.status: executing eggint.h commands
config.status: creating eggint.h : __EGGINT_H
config.status: executing replace-if-changed commands
creating lush.h
config.status: executing catch-make-rebuild commands

Operating System: Darwin 22.6.0
IPv6 Support: yes
Tcl version: 8.5.9 (threaded)

and it fully compiled :)

@michaelortmann michaelortmann changed the title Add yet another tcl search path for MacOS Add yet another tcl search path for macOS Aug 17, 2024
@vanosg vanosg merged commit 54f7ab9 into eggheads:develop Aug 20, 2024
24 checks passed
@vanosg vanosg added this to the v1.10.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants