Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user/chanrecord checking on join #1678

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix user/chanrecord checking on join #1678

merged 1 commit into from
Aug 20, 2024

Conversation

vanosg
Copy link
Member

@vanosg vanosg commented Aug 20, 2024

Found by: DasBrain
Patch by: Geo

One-line summary:
Fix user/chanrecord checking on join

Additional description (if needed):
As part of the account tracking additions, we didn't properly check flag records for a user joining a channel. Thanks to lookup_user_record, this patch now universally searches for a userrecord existing before creating the new channel record and eliminates the previous per-logic-branch checks. This functionality was unaffected in post-join events (mode changes, host changes, etc).

Test cases demonstrating functionality (if applicable):

Before:

[02:42:54] #-HQ# whois geo
HANDLE                           PASS NOTES FLAGS           LAST
geo                              no       0 -               02:42 (#eggtest)
                         #eggtest           k               02:42

-----------------------------

22:42 --> Geo (user@user/geo) has joined #eggtest
22:42 -- Channel #eggtest: 2 nicks (1 op, 0 voices, 1 normal)
<end>

After:

22:43 --> Geo (user@user/geo) has joined #eggtest
22:43 -- Channel #eggtest: 2 nicks (1 op, 0 voices, 1 normal)
22:43 -- Mode #eggtest [+b *!*user@user/geo] by BeerBot
22:43 <-- BeerBot has kicked Geo (...and don't come back.)

Same for auto-op.

Also tested with a host-only user vs an account-only user, success in both cases.

@vanosg vanosg added this to the v1.10.0 milestone Aug 20, 2024
@vanosg vanosg merged commit a688fdd into develop Aug 20, 2024
24 checks passed
vanosg added a commit that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants