Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make error for Fedora 42 #1741

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Jan 17, 2025

Found by: robert-scheck
Patch by: michaelortmann
Fixes: #1740

One-line summary:
Add -std=gnu99, if available, to CFLAGS

Additional description (if needed):
GCC 15 changes the default language version for C compilation from -std=gnu17 to -std=gnu23. See https://gcc.gnu.org/gcc-15/changes.html

Test cases demonstrating functionality (if applicable):
Test with gcc-15-20250112
Before:

/home/michael/opt/gcc-15-20250112/bin/gcc -g -O2 -pipe -Wall -I.. -I..  -DHAVE_CONFIG_H -I/usr/include  -c botcmd.c
botcmd.c: In function ‘bot_filereq’:
botcmd.c:1155:9: error: too many arguments to function ‘f’; expected 0, have 3
 1155 |         f(idx, from, path);
      |         ^ ~~~
make[1]: *** [Makefile:86: botcmd.o] Error 1
make[1]: Leaving directory '/home/michael/projects/eggdrop/src'
make: *** [Makefile:243: eggdrop] Error 2

After:
/home/michael/opt/gcc-15-20250112/bin/gcc -std=gnu99 -g -O2 -pipe -Wall -I.. -I.. -DHAVE_CONFIG_H -I/usr/include -c botcmd.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

botcmd.c:1155:9: error: too many arguments to function ‘f’; expected 0, have 3
1 participant