Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in prpare_response_variables() #117

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Fix bug in prpare_response_variables() #117

merged 4 commits into from
Aug 15, 2024

Conversation

egouldo
Copy link
Owner

@egouldo egouldo commented Aug 15, 2024

Fix bug in case when no standardisation of any datasets resulted in all datasets being standardised and update function documentaiton #88

- #116 add checks for param table argument
- update default behaviour description #102
- line linting / indentation #97
- #88 change default behaviour to `process_response()`, not `standardise_response()` when `is.null(dataset_standardise)`, otherwise function did not allow for case when all datasets should not be Z-standardised
@egouldo egouldo added this to the Software Manuscript Submit milestone Aug 15, 2024
@egouldo egouldo added bug an unexpected problem or unintended behavior documentation breaking change ☠️ API change likely to affect existing code labels Aug 15, 2024
@egouldo egouldo linked an issue Aug 15, 2024 that may be closed by this pull request
@egouldo egouldo merged commit b651869 into main Aug 15, 2024
@egouldo egouldo deleted the 88-patch branch August 15, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code bug an unexpected problem or unintended behavior documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant