order of api call is reversed

[suryansh-egov]

Choose the appropriate template for your PR:

Feature PR

Feature Request

JIRA ID

Module

Description

Related Issues

---

Bugfix PR

Bugfix Request

JIRA ID

Module

Description

Root Cause

Related Issues

---

Release PR

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling during checklist creation to prevent inconsistent states.
  • Enhanced localization process to ensure proper data handling before checklist creation.

• New Features

  • Added error handling for data retrieval from the MDMS service.

• Refactor

  • Adjusted rendering logic for better clarity and organization.

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ast-grep (0.30.1)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js

An unexpected error occurred while running ast-grep.

📝 Walkthrough

Walkthrough

The changes in CreateChecklist.js focus on improving the error handling and localization process during the checklist creation. The onSubmit function is modified to prioritize localization before checklist creation, preventing inconsistent states. Adjustments to useEffect hooks ensure proper setting of serviceCode, while the fetchData function now includes error management for data retrieval. The clearData function is updated for correct configuration resets, and minor JSX rendering logic adjustments enhance clarity. The export statement remains unchanged.

Changes

File	Change Summary
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js	Modifications to onSubmit for error handling and localization; adjustments to useEffect, fetchData, and clearData; minor JSX rendering updates.

Possibly related PRs

• error toast and checklist updates #1805: This PR modifies the onSubmit function in CreateChecklist.js, enhancing error handling and toast notifications, which aligns with the main PR's focus on improving error management during checklist creation.
• added back button, redirected checklist success and fixed null issue … #1894: This PR also updates the onSubmit function in CreateChecklist.js, refining error handling and modifying the success toast message, directly relating to the changes made in the main PR regarding error handling and localization during checklist creation.

Suggested reviewers

• jagankumar-egov

🐰 In a world of checklists, so neat and bright,
Localization now shines, a true delight!
With toasts for errors, we leap and bound,
Creating with joy, where solutions are found.
So hop along, friends, let’s celebrate this cheer,
For every small change brings us closer, my dear! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Reviewing files that changed from the base of the PR and between b3c48dc and 0dee4b2.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js (3 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js (1)

Pattern **/*.js: check

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/pages/employee/CreateChecklist.js (2)

Line range hint 449-472: Localization Upsert Before Checklist Creation Ensures Data Consistency

The changes correctly modify the onSubmit function to perform the localization upsert before creating the checklist. This prevents inconsistent states where the checklist could be created without proper localization. Error handling is appropriately managed to handle failures in the localization step.

---

650-650: Export Statement Includes Necessary Modules

The export of temp_data and CreateChecklist ensures that both are available for import elsewhere in the application. This is appropriate and maintains consistency with module exports.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.