Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change map to be a trait method" #473

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

DaniPopes
Copy link
Contributor

This reverts commit 4c28061.
Fixes #468.
Supersedes #470.

@DaniPopes DaniPopes requested a review from a team as a code owner November 24, 2024 19:14
@DaniPopes DaniPopes requested review from Alex-Fischman and removed request for a team November 24, 2024 19:14
Copy link

codspeed-hq bot commented Nov 24, 2024

CodSpeed Performance Report

Merging #473 will not alter performance

Comparing DaniPopes:revert-4c28061 (cafd51f) with main (1d31817)

Summary

✅ 8 untouched benchmarks

Copy link
Collaborator

@Alex-Fischman Alex-Fischman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alex-Fischman Alex-Fischman merged commit 86cb822 into egraphs-good:main Nov 25, 2024
5 checks passed
@Alex-Fischman
Copy link
Collaborator

Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile time regression
2 participants