Test code #31
Merged
Test code #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oflatt
requested changes
Dec 29, 2023
…acyclic egraphs. Disabled the faster-greedy-dag extractor - the update fuzzer has generated more egraphs that trigger failure
|
The improved random egraph generation now generates egraphs that cause the faster-greedy-dag extractor to fail. |
…s that are more likely to be problematic
|
@oflatt were your change requests addressed? |
mwillsey
requested changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates some semi-random egraphs, runs extractors on them, checks that the extractions are valid, then checks that
the optimal extractions all have the same cost, and then checks that there are no extractions cheaper than the optimal extractions.
I'm happy to improve this. I've not done automated testing in Rust before, so it's easy for me to believe there are better ways.