fix: unauthorized access due to 'web api' enabled by defalut #1091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
据说nps有一个未授权访问漏洞0day,刚才试了一下发现漏洞是存在的。
在配置文件auth_key被注释的情况下,依然可以通过web api进行管理,poc如下:
运行结果:
修复建议:可以在base.go的Prepare函数里加个判断,如果configKey是空,就生成随机字符串赋值。