Merge pull request #130 from ehb54/ehb54-issue-346

[Bug]:Fix code scanning alert - Unsigned difference expression compared to zero
ehb54 · Aug 29, 2024 · eb02443 · eb02443
2 parents 2913bc3 + 5444432
commit eb02443
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/us_somo/develop/src/us_hydrodyn_dad_gui.cpp b/us_somo/develop/src/us_hydrodyn_dad_gui.cpp
@@ -5397,7 +5397,7 @@ void US_Hydrodyn_Dad::update_enables()
    baseline_integral = ( ( US_Hydrodyn * ) us_hydrodyn )->gparams[ "dad_bl_integral" ] == "true";
 
    // pb_timeshift        ->setEnabled( files_selected_count > 0 && files_compatible && files_are_time );
-   pb_timeshift          ->setEnabled( files_selected_count - conc_selected_count > 0 && files_compatible && files_are_time && conc_files.size() );
+   pb_timeshift          ->setEnabled( (int64_t)files_selected_count - conc_selected_count > 0 && files_compatible && files_are_time && conc_files.size() );
    pb_timescale          ->setEnabled( files_selected_count && files_are_time && conc_selected_count == files_selected_count );
    pb_gauss_mode         ->setEnabled( files_selected_count == 1 && files_are_time );
    pb_gauss_start        ->setEnabled( files_selected_count == 1 && files_are_time );

diff --git a/us_somo/develop/src/us_hydrodyn_mals_gui.cpp b/us_somo/develop/src/us_hydrodyn_mals_gui.cpp
@@ -4604,7 +4604,7 @@ void US_Hydrodyn_Mals::update_enables()
    baseline_integral = ( ( US_Hydrodyn * ) us_hydrodyn )->gparams[ "mals_bl_integral" ] == "true";
 
    // pb_timeshift        ->setEnabled( files_selected_count > 0 && files_compatible && files_are_time );
-   pb_timeshift          ->setEnabled( files_selected_count - conc_selected_count > 0 && files_compatible && files_are_time && conc_files.size() );
+   pb_timeshift          ->setEnabled( (int64_t)files_selected_count - conc_selected_count > 0 && files_compatible && files_are_time && conc_files.size() );
    pb_timescale          ->setEnabled( files_selected_count && files_are_time && conc_selected_count == files_selected_count );
    pb_gauss_mode         ->setEnabled( files_selected_count == 1 && files_are_time );
    pb_gauss_start        ->setEnabled( files_selected_count == 1 && files_are_time );

diff --git a/us_somo/develop/src/us_hydrodyn_mals_saxs_gui.cpp b/us_somo/develop/src/us_hydrodyn_mals_saxs_gui.cpp
@@ -5060,7 +5060,7 @@ void US_Hydrodyn_Mals_Saxs::update_enables()
    baseline_integral = ( ( US_Hydrodyn * ) us_hydrodyn )->gparams[ "mals_saxs_bl_integral" ] == "true";
 
    // pb_timeshift        ->setEnabled( files_selected_count > 0 && files_compatible && files_are_time );
-   pb_timeshift          ->setEnabled( files_selected_count - conc_selected_count > 0 && files_compatible && files_are_time && conc_files.size() );
+   pb_timeshift          ->setEnabled( (int64_t)files_selected_count - conc_selected_count > 0 && files_compatible && files_are_time && conc_files.size() );
    pb_timescale          ->setEnabled( files_selected_count && files_are_time && conc_selected_count == files_selected_count );
    pb_gauss_mode         ->setEnabled( files_selected_count == 1 && files_are_time );
    pb_gauss_start        ->setEnabled( files_selected_count == 1 && files_are_time );

diff --git a/us_somo/develop/src/us_hydrodyn_saxs_hplc_gui.cpp b/us_somo/develop/src/us_hydrodyn_saxs_hplc_gui.cpp
@@ -4546,7 +4546,7 @@ void US_Hydrodyn_Saxs_Hplc::update_enables()
    baseline_integral = ( ( US_Hydrodyn * ) us_hydrodyn )->gparams[ "hplc_bl_integral" ] == "true";
 
    // pb_timeshift        ->setEnabled( files_selected_count > 0 && files_compatible && files_are_time );
-   pb_timeshift          ->setEnabled( files_selected_count - conc_selected_count > 0 && files_compatible && files_are_time && conc_files.size() );
+   pb_timeshift          ->setEnabled( (int64_t)files_selected_count - conc_selected_count > 0 && files_compatible && files_are_time && conc_files.size() );
    pb_timescale          ->setEnabled( files_selected_count && files_are_time && conc_selected_count == files_selected_count );
    pb_gauss_mode         ->setEnabled( files_selected_count == 1 && files_are_time );
    pb_gauss_start        ->setEnabled( files_selected_count == 1 && files_are_time );