Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

us_abde: Profile Normalization #122

Merged
merged 4 commits into from
Jul 16, 2024
Merged

us_abde: Profile Normalization #122

merged 4 commits into from
Jul 16, 2024

Conversation

samo38
Copy link
Collaborator

@samo38 samo38 commented Jul 12, 2024

…ximum peak or user selected point

@samo38 samo38 closed this Jul 12, 2024
@samo38 samo38 reopened this Jul 12, 2024
@samo38 samo38 requested review from demeler and SophiaBird95 July 12, 2024 23:10
@demeler
Copy link
Collaborator

demeler commented Jul 16, 2024

Saeed, yes, the last point problem is solved - I no longer see a random value added. However, there is another issue I noticed. When I unclick "Normalize by Maximum" it will still normalize by maximum instead of plotting the unadjusted profiles. Can you please check that one as well?

samo38 added 2 commits July 16, 2024 08:56
…of radius that already set when the user clicks on the limit radius checkbox, and fixed the similar inssue with normalizing on the point selected by the user or maximum peak.
@samo38
Copy link
Collaborator Author

samo38 commented Jul 16, 2024

Fixed the issue with clicking on both the "Limit Radius" and "Normalize by Maximum" when you picked on before. Now it stores the data so that you click on them it plots by last numbers and you don't need to pick them again.

Copy link
Collaborator

@demeler demeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all permutations of normalization options and radial limits - all works as intended.

@demeler demeler merged commit 93c4ea8 into ehb54:master Jul 16, 2024
4 checks passed
@samo38 samo38 deleted the us_abde_322 branch October 9, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants