Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV export for plots #128

Merged
merged 9 commits into from
Sep 2, 2024
Merged

CSV export for plots #128

merged 9 commits into from
Sep 2, 2024

Conversation

doluk
Copy link
Collaborator

@doluk doluk commented Aug 20, 2024

Additions

  1. Adds csv export QToolButton to US_Plot with a new icon
  2. Adds csv export function to US_GuiUtil similar to save_png

Changes

  1. Fixes a minor visual inconsistency in US_Plot caused by the different sizes of buttons and button labels by explicitly setting the size of the buttons.
  2. Fixes an edge case bug in the us_plot3d csv export when plotting a model (plus some extra conditions) resulting in an empty csv file.

@doluk doluk requested a review from ehb54 August 20, 2024 12:15
@demeler
Copy link
Collaborator

demeler commented Aug 21, 2024

One question for Lukas: How does this new feature function for plot windows where there are multiple plot elements in the plot? Or multiple CSV files in different formats that should be exported to capture all of the information in the plot? For example, in a van Holde - Weischet distribution plot we have the extrapolation points and the equations for the linear fits, both elements follow a different structure and couldn't really be saved as a single CSV file.

@doluk doluk requested a review from demeler August 29, 2024 15:17
Copy link
Collaborator

@demeler demeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plot examples from exported data look identical to the original rendition in UltraScan.

@demeler demeler merged commit 6f21039 into ehb54:master Sep 2, 2024
5 checks passed
@demeler
Copy link
Collaborator

demeler commented Sep 3, 2024

Weird, when I pulled #128 again it worked just fine - I can confirm that the csv icon now shows up in Plot Norm program, and it works. Thanks Lukas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants