358 enhancement information needed to register ultrascan #134
Conversation
Merge ehb54/master to ultrascan3
| @@ -431,10 +390,8 @@ void US_License::update( void ) | |||
| if ( firstname == "" || | |||
| lastname == "" || | |||
| institution == "" || | |||
| address == "" || | |||
| state == "" || | |||
| zip == "" || | |||
There was a problem hiding this comment.
Shouldn't this be removed too?
There was a problem hiding this comment.
I guess it can stay, because we init the zip code to be n/a. But the same is true for the address. So for consistency...
There was a problem hiding this comment.
Existing License
Expired License
No License
Had some issues testing this with the SSL/TLS stuff on windows, but fixed that by copying the stuff into the bin folder of a stable release install of Ultrascan.
I tested the Initial registration and updating the license. Worked both without any problems.
The only thing I noticed is, that renewing the license will not remove the old information from the license when updating it. Which means, the information is still send over the internet to a none european server and the information is still stored somewhere on the device. This should be changed so it automatically replaces those information with n/a when updating the license.
This should be an easy thing by just force fully setting the fields in the update function to n/a.
| @@ -431,10 +390,8 @@ void US_License::update( void ) | |||
| if ( firstname == "" || | |||
| lastname == "" || | |||
| institution == "" || | |||
| address == "" || | |||
| state == "" || | |||
| zip == "" || | |||
There was a problem hiding this comment.
I guess it can stay, because we init the zip code to be n/a. But the same is true for the address. So for consistency...
|
The logic needs to stay compatible with older installations which still
supply address and phone number. So the first step is to overwrite the
address and phone info in the database, but yes, all registration info is
still sent to the database, because we need it for the NIH grant. Using
UltraScan is funded by NIH, hence, the American tax payer deserves to know
how many people are using the software.
…On Thu, Oct 3, 2024 at 7:10 AM Lukas Dobler ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Existing License
image.png (view on web)
<https://github.com/user-attachments/assets/3b6926e4-6818-4575-939d-d915e2d398d0>
Expired License
image.png (view on web)
<https://github.com/user-attachments/assets/e7b7b583-8f08-4814-b231-fa2976151505>
No License
image.png (view on web)
<https://github.com/user-attachments/assets/c043aa25-ce3b-4013-af8c-86c7e26ddf74>
Had some issues testing this with the SSL/TLS stuff on windows, but fixed
that by copying the stuff into the bin folder of a stable release install
of Ultrascan.
I tested the Initial registration and updating the license. Worked both
without any problems.
The only thing I noticed is, that renewing the license will not remove the
old information from the license when updating it. Which means, the
information is still send over the internet to a none european server and
the information is still stored somewhere on the device. This should be
changed so it automatically replaces those information with n/a when
updating the license
------------------------------
In gui/us_license.cpp
<#134 (comment)>:
> @@ -431,10 +390,8 @@ void US_License::update( void )
if ( firstname == "" ||
lastname == "" ||
institution == "" ||
- address == "" ||
state == "" ||
zip == "" ||
I guess it can stay, because we init the zip code to be n/a. But the same
is true for the address. So for consistency...
—
Reply to this email directly, view it on GitHub
<#134 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2N7224VL5FL4WQSERHDWDZZU65FAVCNFSM6AAAAABPIMCN62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBVGQ4TAOBQGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
No, I wasn't arguing against the sending of the data in itself. It was about sending the address, phone number and zip code over the internet when no longer required by us. That you need some sort of telemetry data for the grant is absolutely understandable! |
|
The new version of UltraScan no longer captures this information. Older
programs will get replaced by newer programs. Over time, the DB entries for
address and phone number will be overwritten because you have to renew once
a year. This is just for registration purposes. I did not deal with any
other reads of the locally stored information, there may be more work to be
done.
-Borries
…On Thu, Oct 3, 2024 at 8:27 AM Lukas Dobler ***@***.***> wrote:
No, I wasn't arguing against the sending of the data in itself. It was
about sending the address, phone number and zip code over the internet when
no longer required by us. That you need some sort of telemetry data for the
grant is absolutely understandable!
—
Reply to this email directly, view it on GitHub
<#134 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2N72452DRK3SS35QK3VALZZVH47AVCNFSM6AAAAABPIMCN62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJRGU3DKOJSGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
doluk
changed the base branch from
master
to
358-enhancement-information-needed-to-register-ultrascan
doluk
merged commit ab22ea6
into
ehb54:358-enhancement-information-needed-to-register-ultrascan
No description provided.