US_Archive utils class

[samo38]

No description provided.

[ehb54]

@samo38
The US_Archive class is failing CodeQL checks on MPI & GUI

[ehb54]

@samo38
There may be other issues with the CodeQL workflow , but likely needs a dnf install libarchive-devel for the container in the codeql yaml
The other option is to build a new base container with the libarchive-devel preinstalled and push it to dockerhub.

[ehb54]

@samo38
Fixed the mpi build, but not the gui build. Note the codeql creates multiple containers - one for each analysis, so the apt install will needed to be included for the gui also.
Don't need it for somo, since somo isn't using libarchive.

[ehb54]

Don't need it for somo, since somo isn't using libarchive.

[ehb54]

@samo38
As i said earlier:

Don't need it for somo, since somo isn't using libarchive.

I doesn't hurt a lot to have it, just takes a bit longer for the analysis to run. At some point we may push against the limit of container time and have to provide our own container cloud for the analysis, which I'm hoping to avoid.

[samo38]

Sure! I just add it just in case. Will remove it! somo has its own copy of us_tar in the develop directory. Though it is not called anywhere.

[samo38]

To use it in the analyze-mpi, I can call us_archive directly instead of editing us_tar or leave it to use us_tar if it's not necessary now.

[ehb54]

@samo38

To use it in the analyze-mpi, I can call us_archive directly instead of editing us_tar or leave it to use us_tar if it's not necessary now.

I'm concerned about the volume of testing required... lots of clusters, analysis methods etc.
Let's leave it for now and get this version merged.
I think we are ready after the codeql analyses finish.

[samo38]

Places where US_Tar are called:

ultrascan3/programs/us_mpi_analysis/us_mpi_analysis.cpp

Line 175 in f94580f

US_Tar tar;

ultrascan3/programs/us_mpi_analysis/us_mpi_analysis.cpp

Line 2484 in f94580f

US_Tar tar;

using system tar:

ultrascan3/programs/us_reporter_gmp/us_reporter_gmp.cpp

Line 10711 in f94580f

//Archive using US_Tar [does NOT work for filename lengths >=100 char]

[samo38]

So If you'd prefer to leave us_mpi_analysis to use US_Tar for now, do I delete installing libarchive from github workflow? Although it is quit fast to install it with apt-get.

[ehb54]

So If you'd prefer to leave us_mpi_analysis to use US_Tar for now, do I delete installing libarchive from github workflow? Although it is quit fast to install it with apt-get.

I don't see any changes to us_mpi_analysis programs themselves, but the changes did require the codeql apt-get for mpi to succeed. So leave the apt-get for mpi.

I think we can migrate us_mpi_analysis to use us_archive, but want to keep it as a separate issue/pull request due to the required testing. This way, we can get your legacy converter in-place and take our time with the us_mpi_analysis.

[samo38]

Yes you're right! By the way us_mpi_analysis needs the utils to be complied first so libarchive is needed anyway.