Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2DSA s,D correct griding #173

Merged
merged 10 commits into from
Jan 26, 2025
Merged

2DSA s,D correct griding #173

merged 10 commits into from
Jan 26, 2025

Conversation

samo38
Copy link
Collaborator

@samo38 samo38 commented Jan 13, 2025

No description provided.

samo38 added 7 commits January 13, 2025 12:43
@samo38
us_model.cpp: calculate_coefficients() function change the vbar to 1/…
bd50f71 
…vbar of the sedimentation is negative and buoyancy is positive.
@samo38
us_model.cpp: removed the comments on updating the vbar when the buoy…
151d3fa 
…ancy>0 and s<0
@samo38
us_fematch.cpp: force the code to use the vbar from the solution inst…
0612f20 
…ead of the Model table
@samo38
us_model.cpp: comment out updating the vbar when ( s < 0 and buoyancy…
5a005db 
… > 0 ) or ( s > 0 and buoyancy < 0 ). ALso, based on the Eq. 14, there is no f_f0 in the numerator under the square root.
@samo38
us_2dsa.cpp: comment out buoyancy checking here and move it to the 2d…
b56ef21 
…sa_ctrl
@samo38
us_analysis_control_2d.cpp: check the buoyancy before starting the fi…
effa5ec 
…tting.
@samo38
us_fematch: taking back the lines that had been commented out to chec…
07abed8 
…k vbar discrepancy between the model table and solution data
@samo38 samo38 changed the title comment out the updating vbar line in the us_model 2DSA s,D correct grids Jan 21, 2025
@samo38 samo38 changed the title 2DSA s,D correct grids 2DSA s,D correct griding Jan 21, 2025
demeler
demeler approved these changes Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@demeler demeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked a model with and without T,B correction on the desktop and the MPI version, both gave the same results for the 2DSA-IT models.

@demeler demeler merged commit e1242ca into ehb54:master Jan 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demeler demeler demeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samo38 @demeler