Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexey dev issue404: Addresses a number of situations with data savings when one of the optics fails #174

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

alexsav815
Copy link
Collaborator

Tested.

@alexsav815 alexsav815 requested a review from demeler January 17, 2025 01:01
@reecemartin48 reecemartin48 self-requested a review January 17, 2025 22:40
Copy link
Collaborator

@reecemartin48 reecemartin48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an optics type (RI or IP) fails in either R&D or GMP, the user is correctly notified of the failure.
For R&D: After importing the data, the user is informed that the successfully collected optics data was saved, while data from the failed optics was not saved.

  • Run ID: MartinR_IF-Fail_R-D_Test-3_13JAN25-run2235
  • Log file: /rmartin/ultrascan3_tests/IF-Fail_R-D_Test-3_13JAN25

For GMP: After importing the data, the user is notified that although the successfully collected optics data was saved (and the failed optics data was not), the run will not be processed further within the GMP framework due to the optics type failure.

  • Run ID: MartinR_IF-Fail_GMP_Test-3_13JAN25-run2234
  • Log file: /rmartin/ultrascan3_tests/IF-Fail_GMP_Test-3_13JAN25

In cases where the 'STOP' sequence is initiated from the DA GUI during the ‘Live Update Stage’, the program correctly identifies the optics type failure and presents the user with the option to either ignore or save the data from the aborted run.

R&D:

  • Run ID: MartinR_IF-Fail_R-D_Stop_PF-1_16JAN25-run2239
  • Log File: /rmartin/ultrascan3_tests/IF-Fail_R-D_Stop_PF-1_16JAN25

GMP:

  • Run ID: MartinR_IF-Fail_GMP_Stop_PF-2_16JAN25-run2240
  • Log File: /rmartin/ultrascan3_tests/IF-Fail_GMP_Stop_PF-2_16JAN25

These fixes successfully address the issues that prompted the ticket. Both the R&D and GMP programs exhibit the correct and expected behavior.

@reecemartin48 reecemartin48 merged commit ad0bbfd into master Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants