Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add q four-momentum vector #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add q four-momentum vector #93

wants to merge 1 commit into from

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Aug 27, 2024

Briefly, what does this PR introduce?

This PR adds the four-momentum transfer vector.

@wdconinc wdconinc requested a review from a team as a code owner August 27, 2024 15:06
@wdconinc
Copy link
Contributor Author

Discussion in zoom chat:

@rseidl-rcf
Copy link

Discussion in zoom chat:

* Can you provide the definitions of q in the case of the other methods, like DA, Sigma, eSigma? As a comment on that PR would be great.

* For SIDIS measurements, you want to define the q-vector w.r.t to the virtual photon direction.

* Yes, but how do you define this in methods that don't calculate this? E.g. https://github.com/eic/EICrecon/blob/main/src/algorithms/reco/InclusiveKinematicsESigma.cc#L85-L94. We want some invariants (Lorentz even) for the data model, such as q.dot(q) = Q2, regardless of which methods are used.

* It's clear for electron method where we explicitly calculate q, https://github.com/eic/EICrecon/blob/main/src/algorithms/reco/InclusiveKinematicsElectron.cc#L127.

* But the other methods... less clear to me.

Yes, that was a little too naive by me. I need to look up how to do that for DA, and xSIGMA methods. For JB your qvector is just the sum of all hadronic final state 4-momenta minus the incoming hadron 4-momentum.

For clarification, we need to calculate angles and pt relative to the virtual photon direction (ie q vector) and z requires dot products with the q vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants