Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: use subset collection when collecting hits in TrackSeeding (back…
…port of #1050) (#1051) ### Briefly, what does this PR introduce? This fixes a regression introduced in #983 that caused realistic track seeding to fail. Essentially, you cannot just add an object from one podio collection into another podio collection "by reference", i.e. without cloning. You can do that with pointers in std::vector, which was done here before #983. We can achieve the same behavior in podio, but we have to be more intentional about it and define a subset collection. Of course, podio complains loudly when you try to add an object from one collection into another collection. It emits an exception: `Object already in a collection. Cannot add it to a second collection`. But JANA2 eats that exception and doesn't even print it 😠 TODO: - [x] check diffs ### What kind of change does this PR introduce? - [x] Bug fix (issue: no track seeding results after #983) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators @ShujieL ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? Yes, CentralTrackSeedingResults and dependents are restored. ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? ### Does this PR change default behavior?
- Loading branch information