Skip to content

Commit

Permalink
fix: rm unused TrackProjectorConfig (#1319)
Browse files Browse the repository at this point in the history
### Briefly, what does this PR introduce?
This PR removes the unused TrackProjectorConfig stuct. Instead of
expanding the use of this algorithm, we should be focusing on
TrackPropagation for filling track segments.

### What kind of change does this PR introduce?
- [x] Bug fix (issue: unused config struct)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
No.
  • Loading branch information
wdconinc authored Mar 4, 2024
1 parent baf8eb8 commit fb30961
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 25 deletions.
4 changes: 1 addition & 3 deletions src/algorithms/tracking/TrackProjector.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include <vector>

#include "ActsGeometryProvider.h"
#include "TrackProjectorConfig.h"
#include "algorithms/interfaces/WithPodConfig.h"


Expand All @@ -21,8 +20,7 @@ namespace eicrecon {
*
* \ingroup tracking
*/
class TrackProjector:
public eicrecon::WithPodConfig<TrackProjectorConfig> {
class TrackProjector {

public:

Expand Down
19 changes: 0 additions & 19 deletions src/algorithms/tracking/TrackProjectorConfig.h

This file was deleted.

4 changes: 1 addition & 3 deletions src/global/tracking/TrackProjector_factory.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,12 @@
#include <vector>

#include "algorithms/tracking/TrackProjector.h"
#include "algorithms/tracking/TrackProjectorConfig.h"
#include "extensions/jana/JOmniFactory.h"

namespace eicrecon {

class TrackProjector_factory :
public JOmniFactory<TrackProjector_factory, TrackProjectorConfig> {
public JOmniFactory<TrackProjector_factory> {

private:
using AlgoT = eicrecon::TrackProjector;
Expand All @@ -33,7 +32,6 @@ class TrackProjector_factory :
public:
void Configure() {
m_algo = std::make_unique<AlgoT>();
m_algo->applyConfig(config());
m_algo->init(m_ACTSGeoSvc().actsGeoProvider(), logger());
}

Expand Down

0 comments on commit fb30961

Please sign in to comment.