Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add header to compact files with liaisons #64

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/linux-eic-shell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,27 @@ jobs:
sudo apt-get install -y libxml2-utils
find compact/ -name "*.xml" -exec xmllint {} \; > /dev/null

xmllint-code-owners:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: |
sudo apt-get update
sudo apt-get install -y libxml2-utils
# find all xml files, which succeed the xpath query,
# then print the filename, then the xpath query string
# xpath: info elements where author attribute starts with @
find compact -name "*.xml" \
-exec xmllint --xpath "/*/info/@author[starts-with(.,'@')]" {} \; \
-printf "%p " \
-exec xmllint --xpath "string(/*/info/@author[starts-with(.,'@')])" {} \; \
| grep -v 'author=' | sort > .github/CODEOWNERS
- uses: actions/upload-artifact@v3
with:
name: CODEOWNERS
path: .github/CODEOWNERS
if-no-files-found: error

list-detector-configs:
runs-on: ubuntu-latest
outputs:
Expand Down
9 changes: 7 additions & 2 deletions compact/ecal/barrel_interlayers.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@
<!-- Active AstroPix layers: 1-3-5-6 -->

<lccdd>
<info name="ecal_barrel_interlayers.xml"
title="Barrel ECAL - Imaging Calorimeter"
author="@mariakzurek"
url="https://github.com/mariakzurek"
status="development"
version="1.0"
><comment/></info>

<display>
</display>
<define>
<comment>
---------------------------------------
Expand Down
8 changes: 8 additions & 0 deletions compact/ecal/forward_scfi.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
<!-- Copyright (C) 2022 Whitney Armstrong, Chao Peng, Sylvester Joosten -->

<lccdd>
<info name="ecal_forward_scfi.xml"
title="Forward ECAL - Detailed ScFi Description"
author="@jizhongling"
url="https://github.com/jizhongling"
status="development"
version="1.0"
><comment/></info>

<define>
<constant name="EcalEndcapP_FiberRadius" value="0.235*cm"/>
<constant name="EcalEndcapP_FiberOffset" value="0.5*mm"/>
Expand Down
9 changes: 9 additions & 0 deletions compact/far_backward/lumi.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@

<lccdd>

<info name="lumi.xml"
title="Luminosity Subsystem"
author="@dhevang"
url="https://github.com/dhevang"
status="development"
version="1.0"
><comment/></info>


<include ref="lumi/exit_window.xml"/>
<include ref="lumi/collimator.xml"/>
<include ref="lumi/lumi_magnets.xml"/>
Expand Down
8 changes: 8 additions & 0 deletions compact/pid/dirc.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@

<lccdd>

<info name="dirc.xml"
title="High Performance DIRC"
author="@rdom"
url="https://github.com/rdom"
status="development"
version="1.0"
><comment/></info>

<comment>
DIRC consists of 12 (default) identical modules making a barrel.
Each DIRC module consists of:
Expand Down
8 changes: 8 additions & 0 deletions compact/pid/drich.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@

<lccdd>

<info name="drich.xml"
title="Dual RICH"
author="@c-dilks"
url="https://github.com/c-dilks"
status="development"
version="1.0"
><comment/></info>

<define>
<!-- vessel (=snout+tank) geometry -->
<constant name="DRICH_length" value="ForwardRICHRegion_length"/> <!-- overall vessel length -->
Expand Down
2 changes: 1 addition & 1 deletion compact/tracking/mpgd_barrel.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<lccdd>
<info name="mpgd_barrel.xml"
title="Micro Pattern Gas Detectors"
author="mposik1983"
author="@mposik1983"
url="https://github.com/mposik1983"
status="development"
version="1.0"
Expand Down
9 changes: 9 additions & 0 deletions compact/tracking/silicon_barrel.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
<!-- Copyright (C) 2022 Sylvester Joosten, Wouter Deconinck, Shujie Li -->

<lccdd>
<info name="silicon_barrel.xml"
title="Stave-like Silicon Outer Barrel"
author="@ShujieL"
url="https://github.com/ShujieL"
status="development"
version="1.0"
><comment/>
</info>

<define>
<comment>
Main parameters - this is for the more realistic June 2022 design
Expand Down
8 changes: 8 additions & 0 deletions compact/tracking/silicon_disks.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
<!-- Copyright (C) 2022 Sylvester Joosten, Wouter Deconinck, Shujie Li -->

<lccdd>
<info name="silicon_disks.xml"
title="Silicon Disk Tracker"
author="@ShujieL"
url="https://github.com/ShujieL"
status="development"
version="1.0"
><comment/>
</info>
<comment>
Main parameters. June 2022 setup with symmetric disk locations.
Here to comply with the ACTS translation onion structure we have:
Expand Down
8 changes: 8 additions & 0 deletions compact/tracking/support_service_craterlake.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
<!-- Copyright (C) 2022 Sylvester Joosten, Shujie Li -->

<lccdd>
<info name="support_service_craterlake.xml"
title="Tracker support structure and service materials"
author="@ShujieL"
url="https://github.com/ShujieL"
status="development"
version="1.0"
><comment/>
</info>
<comment>
Tracker support and service materials for ePIC-craterlake tracking geometry.
See https://indico.bnl.gov/event/19854/#1-updated-epic-tracking-config
Expand Down
8 changes: 8 additions & 0 deletions compact/tracking/vertex_barrel.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
<!-- Copyright (C) 2022 Sylvester Joosten, Whitney Armstrong, Shujie Li -->

<lccdd>
<info name="vertex_barrel.xml"
title="Silicon Vertex Tracker"
author="@ShujieL"
url="https://github.com/ShujieL"
status="development"
version="1.0"
><comment/>
</info>
<define>
<comment>
Main parameters
Expand Down
14 changes: 11 additions & 3 deletions compact/unused/ecal_forward_homogenous.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,17 @@
<!-- Copyright (C) 2022 Whitney Armstrong, Chao Peng, Sylvester Joosten -->

<lccdd>
<comment>
Simplified homogenous implementation of the forward ScFi calorimeter
</comment>
<info name="ecal_forward_homogeneous.xml"
title="Forward ECAL - Homogeneous Equivalent Description"
author="@jizhongling"
url="https://github.com/jizhongling"
status="development"
version="1.0"
>
<comment>
Simplified homogenous implementation of the forward ScFi calorimeter
</comment>
</info>

<define>
<constant name="EcalEndcapP_FiberRadius" value="0.235*cm"/>
Expand Down