-
Notifications
You must be signed in to change notification settings - Fork 47
Central ePIC beam pipe model updates v250331 implementation #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nat93
wants to merge
38
commits into
main
Choose a base branch
from
new_central_beampipe_model_v250331_implementation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… racetrack and circular pipe profiles. No geometry overlaps are detected, except for vacuum. Will be fixed in the next commits.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…ithub.com:eic/epic into new_central_beampipe_model_v250331_implementation Merge
…the new central beam pipe. Added interface vacuum volums between racetrack and circular beam pipes.
for more information, see https://pre-commit.ci
### Briefly, what does this PR introduce? This PR changes another instance of /work/eic2 to /volatile/eic
The npsim check failures are resolved by #843, so a rebase will address those. |
… racetrack and circular pipe profiles. No geometry overlaps are detected, except for vacuum. Will be fixed in the next commits.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci Rebased from origin
…the new central beam pipe. Added interface vacuum volums between racetrack and circular beam pipes.
for more information, see https://pre-commit.ci
…ithub.com:eic/epic into new_central_beampipe_model_v250331_implementation Pull from origin
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: far-forward
Deterctors for small-angle particles
topic: infrastructure
Regarding build system, CI, CD
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Updates the central beam pipe model following the recent CAD drawing released by the EIC vacuum group: https://indico.bnl.gov/event/27631/#26-update-on-beampipe-modeling
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
So far, no geometry overlaps have been detected.
Does this PR change default behavior?
Yes, it alters the beam pipe geometry and the material budget encountered by radiation passing through it.