Skip to content

Central ePIC beam pipe model updates v250331 implementation #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

nat93
Copy link

@nat93 nat93 commented Apr 10, 2025

Briefly, what does this PR introduce?

Updates the central beam pipe model following the recent CAD drawing released by the EIC vacuum group: https://indico.bnl.gov/event/27631/#26-update-on-beampipe-modeling

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: Model updates

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

So far, no geometry overlaps have been detected.

Does this PR change default behavior?

Yes, it alters the beam pipe geometry and the material budget encountered by radiation passing through it.

@github-actions github-actions bot added topic: infrastructure Regarding build system, CI, CD topic: far-forward Deterctors for small-angle particles labels Apr 10, 2025
Andrii Natochii and others added 6 commits April 11, 2025 09:47
@nat93 nat93 self-assigned this Apr 11, 2025
pre-commit-ci bot and others added 2 commits April 11, 2025 18:33
### Briefly, what does this PR introduce?
This PR changes another instance of /work/eic2 to /volatile/eic
@wdconinc
Copy link
Contributor

The npsim check failures are resolved by #843, so a rebase will address those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: far-forward Deterctors for small-angle particles topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants