Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple docker file #44

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Simple docker file #44

merged 2 commits into from
Dec 26, 2023

Conversation

reutsharabani
Copy link

For people who want to just use it without messing around too much

@reutsharabani reutsharabani mentioned this pull request Dec 22, 2023
@eidelen eidelen self-assigned this Dec 26, 2023
@eidelen
Copy link
Owner

eidelen commented Dec 26, 2023

Hi Reut,
I do know little about docker. But I am thankful for your contribution and I would like to merge it. Here some minor issues:

  • Could you place your docker file in new directory called docker? There might come more of these.
  • Could you write few lines on how to use this docker file? In my opinion, a good place could be the Installation section of the readme file:
    # Installation

Thank you,
Adrian

@reutsharabani
Copy link
Author

Hi Adrian,

Thank you for this repo! I used it for my chest CT.

I made the changes you asked for.

Docker is a virtualization layer which in this context allows you to run the project without installing things locally (I created a simple docker file using the ubuntu package, but it can be better).

All you need is docker installed which is pretty common nowdays.

I used this docker file myself, but it would be best if someone can try it as well to confirm that it works.

@eidelen eidelen merged commit a86cf34 into eidelen:master Dec 26, 2023
2 checks passed
@eidelen
Copy link
Owner

eidelen commented Dec 26, 2023

Hi Reut,
Thank you. It is merged.
Adrian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants