Add Kubernetes CRD client and schemas #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-persson
requested review from
fredjn and
andmat900
and removed request for
a team
|
Dataset requires some more work. |
t-persson
force-pushed
the
etos-controller
branch
from
816929a to
217a698
Compare
andmat900
reviewed
Aug 19, 2024
fredjn
requested changes
Sep 23, 2024
| annotations: Optional[dict[str, str]] = None | ||
|
|
||
|
|
||
| class Image(BaseModel): |
There was a problem hiding this comment.
Not that it matters, but Image is only used with TestRunSepc making it not very commonly used between Kubernetes resources.
t-persson
force-pushed
the
etos-controller
branch
from
a7a7d62 to
89bf475
Compare
andmat900
reviewed
Oct 9, 2024
fredjn
previously approved these changes
Oct 10, 2024
|
|
||
|
|
||
| class EnvironmentSpec(BaseModel): | ||
| """EnvironmentSpec is the specification of a Environment Kubernetes resource.""" |
Also moved the NotFound check to the 'exists' method.
fredjn
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
eiffel-community/etos#242
Description of the Change
Added schemas and helper methods for interacting with ETOS kubernetes resources.
Alternate Designs
I had these helpers in each service before, but that cause so much friction any time the packages changed as I needed to update every single one and make the correct change. While we still have to update every service when the library updates, at least we don't have to make the same code change multiple times.
Possible Drawbacks
Explained briefly in Alternate Designs.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]