Skip to content

Provide name of conflicting repository #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

berenddeboer
Copy link
Contributor

Better error message in case of conflicts.

@berenddeboer
Copy link
Contributor Author

BTW, the documentation led me to believe you can actually have the same package name in a repository twice. See "Using your own IRON packages locally". There an example is given where you have to select the repository. But the code does not seem the support this.

@@ -137,8 +137,8 @@ feature -- Execute
if a_iron.installation_api.is_package_installed (p.item) then
print (" [installed] ")
end
if l_has_conflict then
print (" [conflict!] ")
if l_has_conflict and then attached l_package_names.item (p.item.identifier) as l_earlier_package then
Copy link
Member

@jocelyn jocelyn Sep 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do

if l_has_conflict then
    if attached l_package_names.item (p.item.identifier) as l_earlier_package then
        print (" [ignoring this package as it is also listed in the " + l_earlier_package.repository.location_string + " repository!] ")
    else
        print (" [Conflict!] ")
    end

otherwise, the conflict may not be reported... even if it is likely that l_earlier_package is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants