test(types): fix flaky blob reconstruct when len == 0 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvolin
force-pushed
the
fix/flaky-blob-reconstruct-test
branch
from
909679d to
bf6f195
Compare
fl0rek
reviewed
Feb 12, 2025
| @@ -489,7 +489,7 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn reconstruct_not_sequence_start() { | |||
| let len = rand::random::<usize>() % 1024 * 1024; | |||
| let len = rand::random::<usize>() % (1024 * 1024) + 1; | |||
There was a problem hiding this comment.
after double checking operator precedence etc.. maybe it could be just:
Suggested change
| let len = rand::random::<usize>() % (1024 * 1024) + 1; | |
| let len : usize = rand::random_range(1..=(1024*1024) + 1); |
Upper and lower limits are immediately visible this way, no need to do the maths. Similarly those below.
There was a problem hiding this comment.
sounds good, but for this we'd need to upgrade rand
oblique
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.