Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add CODEOWNERS #45

Merged
merged 3 commits into from
May 28, 2024
Merged

chore: Add CODEOWNERS #45

merged 3 commits into from
May 28, 2024

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented May 24, 2024

Description

I keep forgetting to add reviewers when a PR is ready 🙈 . This PR adds code owners so they are automatically requested for review when someone opens a pull request.

Add CODEOWNERS file with the dev team so when a PR is set to ready it will add the team as reviewers.
The file has been placed in the .github/ folder but can also be placed in the root or a docs/ folder.

I considered adding @eigerco/polka-storage but some people in that team are not actively involved in the development of this project.

Additional resources

GitHub code owners doc

Add CODEOWNERS file with the dev team so when a PR is set to
ready it will add the team as reviewers.
@aidan46 aidan46 self-assigned this May 24, 2024
@aidan46 aidan46 added the ready for review Review is needed label May 24, 2024
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing idea!

@aidan46 aidan46 enabled auto-merge May 27, 2024 17:02
@aidan46 aidan46 disabled auto-merge May 27, 2024 17:02
@aidan46 aidan46 enabled auto-merge May 27, 2024 17:03
@aidan46 aidan46 added ready for review Review is needed and removed ready for review Review is needed labels May 27, 2024
@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels May 28, 2024
@aidan46 aidan46 merged commit 87f626e into develop May 28, 2024
3 checks passed
@aidan46 aidan46 deleted the chore/add-codeowners branch May 28, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants