Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI optimization #50

Merged
merged 11 commits into from
May 28, 2024
Merged

CI optimization #50

merged 11 commits into from
May 28, 2024

Conversation

serg-temchenko
Copy link
Contributor

@serg-temchenko serg-temchenko commented May 28, 2024

Description

As described in the related issue #49:

Currently, our CI runner has limited resources. As a result, our CI build takes more than an hour, which is unacceptable for a healthy contribution process. To resolve this issue temporarily and focus on the current business logic, we need to simplify the CI workflow. We will improve this later by using a better instance with on-demand functionality as described in this thread.

To revert the changes made for simplification, you can execute a revert of commit ca1fce49e2f3e21a38a6a4167b15029ed856c2c0.

Also, removed toolchain installation steps, as well as Taplo and caching, since we are using a self-hosted runner where context is shared by default.

After all these changes. CI run reduced to ~36 minutes.

image

Important points for reviewers

CI related code should be treated as a temporary solution which should be reverted when self hosted runner will be configured.

Checklist

  • Are there important points that reviewers should know?
    • If yes, which ones?
  • Make sure that you described what this change does.
  • If there are follow-ups, have you created issues for them?
  • Have you tested this solution?
  • Were there any alternative implementations considered?
  • Did you document new (or modified) APIs?

@serg-temchenko serg-temchenko self-assigned this May 28, 2024
@serg-temchenko serg-temchenko added the ready for review Review is needed label May 28, 2024
@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels May 28, 2024
@serg-temchenko serg-temchenko marked this pull request as ready for review May 28, 2024 04:33
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
th7nder
th7nder previously approved these changes May 28, 2024
jmg-duarte
jmg-duarte previously approved these changes May 28, 2024
Copy link
Collaborator

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the comments on the profile.ci, great work!

@serg-temchenko serg-temchenko dismissed stale reviews from jmg-duarte and th7nder via df825e1 May 28, 2024 09:22
jmg-duarte
jmg-duarte previously approved these changes May 28, 2024
@serg-temchenko serg-temchenko added ready for review Review is needed and removed ready for review Review is needed labels May 28, 2024
@cernicc cernicc merged commit ab04704 into develop May 28, 2024
3 checks passed
@cernicc cernicc deleted the no-ref/ci-time-improvement branch May 28, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants