-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI optimization #50
Merged
Merged
CI optimization #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serg-temchenko
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
May 28, 2024
th7nder
requested changes
May 28, 2024
th7nder
previously approved these changes
May 28, 2024
jmg-duarte
previously approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the comments on the profile.ci
, great work!
jmg-duarte
previously approved these changes
May 28, 2024
serg-temchenko
added
ready for review
Review is needed
and removed
ready for review
Review is needed
labels
May 28, 2024
th7nder
approved these changes
May 28, 2024
cernicc
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the related issue #49:
Also, removed toolchain installation steps, as well as Taplo and caching, since we are using a self-hosted runner where context is shared by default.
After all these changes. CI run reduced to ~36 minutes.
Important points for reviewers
CI related code should be treated as a temporary solution which should be reverted when self hosted runner will be configured.
Checklist