Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/colamanga #401

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Silverbullet069
Copy link

I've added a separate www.colamanga.com module by automating AES decryption process and fix a bug that ignore imagehandler.

@eight04
Copy link
Owner

eight04 commented Feb 17, 2025

Good job! 👍

I haven't have time to review the entire module. Did you solve the problem here:
#398 (comment)
#400 (comment)

@Silverbullet069
Copy link
Author

Silverbullet069 commented Feb 17, 2025

Good job! 👍

Thank you sir :")

I haven't have time to review the entire module. Did you solve the problem here: #398 (comment) #400 (comment)

You bet I did:

  • For #400 (comment), turn out the server didn't require cookies to download images, the authentication mechanism lies in origin: header setting.
  • For #398 (comment):
    • Problem 1, 2 and 5: I've stopped thinking about Blob() since getting large data out of Deno is a very slow process.
    • Problem 3: it's actually my mistake, imagehandler return value is ext, bin and not (ext, bin), which is a tuple.
    • Problem 4, I made a Deno-Python hybrid solution for key retrieval. AES decryption is done entirely in Python. Now it takes 0.008 seconds for an image with 190KB.

I found out there is a bug in your code. It seems that after downloading the image, you rename the temp file to final file but forget to rewrite its binary data returned from imagehandler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants