Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting/theme functionality separation #38

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

brettsmason
Copy link
Member

This started off over a year ago with the intention of enforcing our coding standards through the use of Husky and lint-staged. Whilst both of those featured have been added (though enforcing of these is currently disabled until we can confirm everyone is happy).

This PR now includes:

  • Moving Nebula to an npm workspace - this has the benefit of being able to run all project build tools from the project root
  • Add nebula core mu-plugin - moves all the functionality that should be project specific, not theme specific here (eg post types and taxonomies).
  • Add nebula blocks - project specific blocks should now belong here. This has the added benefit of fixing the current inability we have to include interactive blocks in a project without having to create a new plugin each time, due to the build tool limitations.
  • Add PostType and Taxonomy abstract classes for easier class and post type registration
  • Standardise how classes are loaded in the same way as Pulsar for familiarity

I'd welcome any feedback, testing or issues before this becomes the new default.

@brettsmason brettsmason marked this pull request as draft November 6, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant