-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activty Import not working after 5.10.4 upgrade #23
Comments
Possibly going wrong in the validateField function? That gets an options array for activities eg Meeting => 'Meeting' etc and tries to match the activity_type_id (an integer) against it..and fails. |
What version were you on before upgrading? I can't think of any recent relevant changes |
4.6.38 I also can't find 'Activity name' or 'Activity label' in the 'matching civicrm field' drop down. These would maybe provide a workaround to the Activity type ID? |
Steps to reproduce on https://dmaster.demo.civicrm.org:
I also get an error on the site on going to https://dmaster.demo.civicrm.org/civicrm/csvimporter/import:
|
Is this on the released version of the latest from master - I recently merged this which may change it - not sure in which direction There were no significant relevant changes in civicrm 5.10 - unless you were upgrading rom a much older version |
It was on 5.13.alpha1 |
now you've confused me - 5.13.alpha1 is current master - you didn't upgrade from 5.13.alpha1 to 5.10 surely. Ah I meant master of this extension not master of core |
I meant the version of dmaster demo (5.13.alpha1) where you can reproduce the issue using v1.3 of this extension. |
Hi Were you able to reproduce the issue on dmaster demo? |
@mikantchap did you see the above fix? Are you able to see if it works for you? |
@eileenmcnaughton what version of this extension has those changes? Is it 1.4? ie https://github.com/eileenmcnaughton/nz.co.fuzion.csvimport/releases/tag/1.4 |
@mikantchap it was in master - I just dropped 1.5 so you can try the latest merged code |
I am still getting errors on dmaster demo - please tell me if I doing something wrong? Version 1.5 Create a csv file containing: (129 is an existing contact). Go to https://dmaster.demo.civicrm.org/civicrm/csvimporter/import Match import as per screenshot: The one line is skipped because you get errors: Reason | Activity Date | Activity Type ID | Subject | - do not import - | Activity Source Contact Invalid value for field (activity_type_id) => 1 | 20190319 16:30 | 1 | test | Meeting | 129 |
Any more thoughts on this? Thanks Mike |
@eileenmcnaughton Date,Activity Type ID,Subject,Appt type,Source ie change the 'Activity Type ID' field content to the activity type name, then it imports OK. But this is just changing the data to workaround the bug. I doubt I would be able to persuade the end user to do this. |
We've had this discussion about the core import too (there were people going to write some unit tests but it stalled there) |
bump |
Tried a couple of different CSV imports for activities eg
Date,Activity Type ID,Subject,Appt type,Source
20190319 16:30,1,test,Meeting,13361
Get an error:
Invalid value for field (activity_type_id) => 1
or whatever Activity Type ID was specified.
The text was updated successfully, but these errors were encountered: