Fix Field Options Caching in getFieldOptionsMeta() #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might fix the issue with #23. Sorry about not testing this fully in the last update. |
|
Thanks @vinuvarshith - I guess without having unit tests this extension is pretty vulnerable :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In getFieldOptionsMeta() function, the recent update added a simple caching logic so we dont call 'getoptions' repeatedly. But it didnt take into account for the field name when caching and so breaks when using multiple option fields for a given entity. This was somehow missed in the last update.
Before
Using multiple options fields in an import fails.
After
Using multiple options fields in an import works as expected.