Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compile public #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RangelReale
Copy link

To be able to use the dbc file to decode messages, it must be parsed and its defs must be consolidated.
This is done in the internal generate package, so it can't be used by external programs.

This PR makes the compilation part a public package.

@RangelReale RangelReale requested a review from a team as a code owner December 27, 2023 10:15
@maxekman
Copy link
Member

Can a smaller part of the generate package be public? Do you have some ideas on this?

@RangelReale
Copy link
Author

My need is to decode CAN messages using a DBC file, but for that I need the compiler to consolidate all the information, but today it is limited to the code generator, I don't know if you want to have this possibility in this library.

Just returning the Defs and the warnings probably should be enough.

@Jassob Jassob added the api API changes label May 16, 2024
@Jassob
Copy link
Member

Jassob commented May 27, 2024

Hello @RangelReale! We're actually duplicating this code internally as well, so I think it makes sense that we make parts of it public.

I'll look into it a bit more in the close future!

@Edholm Edholm requested review from maxekman and Jassob and removed request for a team September 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants