Skip DBC comments #242
Open
Skip DBC comments #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you describe a little bit about the current behavior and how this changes that? |
|
Currenly comments are not ignored, so when parsing a line like this: we get errors, as there is supposed to be no more data after the version string. |
|
According to http://www.mcu.so/Microcontroller/Automotive/dbc-file-format-documentation_compress.pdf it seems like the comment format to use in DBC files are We're hesistant to include non-standard behavior, as it could potentially conflict with other tooling. Feel free to update the PR with this comment style, if you still want this feature :) |
Jassob
requested changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.