refactor!: use slog for logging #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently externalclock takes a logr and uses it for some debug logging. Since log/slog now exists in std library we should use it. This commit removes logr dependency with using slog directly. This is a breaking change as the signature for externalclock.New changes. Previous calls to `externalclock.New(logr, time)` can safely drop the `logr` argument.
maxekman
approved these changes
May 20, 2024
erikbohnsack
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently externalclock takes a logr and uses it for some debug
logging. Since log/slog now exists in std library we should use it.
This commit removes logr dependency with using slog directly.
This is a breaking change as the signature for externalclock.New
changes. Previous calls to
externalclock.New(logr, time)can safelydrop the
logrargument.