feat: "revert: preserve auth errors in cloudrunner.WrapTransient"

This reverts commit d62a6a3. This commit breaks the API description of only forwarding transient (retryable) errors.
einride · Sep 30, 2024 · 646342a · 646342a
1 parent 0ebf2af
commit 646342a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/clouderror/wrap.go b/clouderror/wrap.go
@@ -35,7 +35,7 @@ func WrapTransient(err error, msg string) error {
 func WrapTransientCaller(err error, msg string, caller Caller) error {
 	if s, ok := status.FromError(err); ok {
 		switch s.Code() {
-		case codes.Unavailable, codes.DeadlineExceeded, codes.Canceled, codes.Unauthenticated, codes.PermissionDenied:
+		case codes.Unavailable, codes.DeadlineExceeded, codes.Canceled:
 			return &wrappedStatusError{status: status.New(s.Code(), msg), err: err, caller: caller}
 		}
 	}

diff --git a/clouderror/wrap_test.go b/clouderror/wrap_test.go
@@ -39,16 +39,6 @@ func Test_WrapTransient(t *testing.T) {
 			err:          status.Error(codes.Unavailable, "transient"),
 			expectedCode: codes.Unavailable,
 		},
-		{
-			name:         "codes.Unauthenticated",
-			err:          status.Error(codes.Unauthenticated, "transient"),
-			expectedCode: codes.Unauthenticated,
-		},
-		{
-			name:         "codes.PermissionDenied",
-			err:          status.Error(codes.PermissionDenied, "transient"),
-			expectedCode: codes.PermissionDenied,
-		},
 		{
 			name: "wrapped transient",
 			err: Wrap(