Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: shutdown otel resource before exiting #690

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

alethenorio
Copy link
Contributor

@alethenorio alethenorio commented Aug 6, 2024

relates to PE-963

BREAKING CHANGE: removed SHUTDOWNDELAY feature

run.go Show resolved Hide resolved
relates to [PE-963](https://einride.atlassian.net/browse/PE-963)

BREAKING CHANGE: removed SHUTDOWNDELAY feature
@alethenorio alethenorio force-pushed the handle-otel-shutdown branch from 084b5ca to 57d12b4 Compare August 6, 2024 14:21
@alethenorio alethenorio marked this pull request as ready for review August 8, 2024 14:47
@alethenorio alethenorio requested a review from a team as a code owner August 8, 2024 14:47
Copy link

@Imrandiva Imrandiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alethenorio alethenorio merged commit 2a18e85 into master Aug 9, 2024
1 check passed
@alethenorio alethenorio deleted the handle-otel-shutdown branch August 9, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants